libnghttp2: Improve CMake handling #26068
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Nov 29, 2024
Comment on lines
+83
to
+87
| tc.cache_variables["LIBEV_FOUND"] = True | ||
| tc.cache_variables["LIBCARES_FOUND"] = True | ||
| tc.cache_variables["LIBBROTLIENC_FOUND"] = True | ||
| tc.cache_variables["LIBBROTLIDEC_FOUND"] = True | ||
| tc.cache_variables["LIBXML2_FOUND"] = True |
There was a problem hiding this comment.
For testing until I discuss with the team
AbrilRBS
commented
Nov 29, 2024
Comment on lines
+94
to
+106
| # Disable find_package to not scare the user with system libs being picked | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libevent"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libbrotlienc"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libbrotlidec"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libngtcp2"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libngtcp2_crypto_quictls"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libnghttp3"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libbpf"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Systemd"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_LibXml2"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libev"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libcares"] = True # Examples only | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Libbrotli"] = True # Examples only |
There was a problem hiding this comment.
For testing too, ensuring we're not missing any requirements for the lib
AbrilRBS
commented
Nov 29, 2024
| tc.cache_variables["JANSSON_FOUND"] = True | ||
|
|
||
| # Disable Python finding so we don't build docs | ||
| tc.cache_variables["CMAKE_DISABLE_FIND_PACKAGE_Python3"] = True |
There was a problem hiding this comment.
This one is NOT for testing and will remain after the PR leaves draft, it avoids cmake from trying to build the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into libcurl for #26063 I noticed libnghttp2 was pulling system dependencies.
This turned out to be mostly a false positive, but for some cases, that was still the case.
This PR aims to fix that, and also fix compilation for non-default options